Declaring and setting variable in upsert SQL Server query no

Declaring and setting variable in upsert SQL Server query no



I have a problem with declaring and setting variable in my upsert sql query.


public void UpdateTrippingTariff(List<TrippingTariffTransaction> obj)

using (IDbConnection connection = ConnectionManager.Connection)

string qry = "";

foreach (var details in obj.ToList())

qry = "DECLARE @TripTariffTransactionID as BIGINT;";
qry += "SET @TripTariffTransactionID = (SELECT Id FROM [dbo].[TrippingTariffTransaction] WHERE Trip = @Trip AND TrippingDistanceId = @TrippingDistanceId AND TrippingTariffId = @TrippingTariffId);";
qry += @" IF (@TripTariffTransactionID != 0)
UPDATE [dbo].[TrippingTariffTransaction]
SET Price = @Price
WHERE Id = @TripTariffTransactionID
ELSE
INSERT INTO [dbo].[TrippingTariffTransaction]
(TrippingTariffId, Trip, Price, TrippingDistanceId, IsActive)
VALUES (@TrippingTariffId, @Trip, @Price, @TrippingDistanceId, @IsActive);
SET @TripTariffTransactionID = (SELECT CAST(SCOPE_IDENTITY() as BIGINT));";

qry += @"INSERT INTO [dbo].[TrippingTariffTransactionAuditTrail]
(LogDatetime, MasterlistId, ComputerName, TrippingTariffTransactionID, Activity)
VALUES (GETDATE(), @MasterlistId, @ComputerName, @TripTariffTransactionID, @Activity)";

if (connection.State == ConnectionState.Closed)

connection.Open();


connection.Execute(qry, details);
connection.Close();





I'm getting a null values in the TripTariffTransactionID column in the TrippingTariffTransactionAuditTrail table.


TripTariffTransactionID


TrippingTariffTransactionAuditTrail



What should I change on my query? Thanks in advance





How are you setting your command parameters?
– Parrish Husband
Aug 28 at 1:42





@ParrishHusband kindly check again sir
– Newbieprog
Aug 28 at 1:54





@TripTariffTransactionID != 0 != @TripTariffTransactionID IS NOT NULL
– Ivan Starostin
Aug 28 at 5:04


@TripTariffTransactionID != 0


@TripTariffTransactionID IS NOT NULL




1 Answer
1



I solved my problem using this approach


public void UpdateTrippingTariff(List<TrippingTariffTransaction> obj)

using (IDbConnection connection = ConnectionManager.Connection)

string qry = "";
foreach (var details in obj.ToList())

qry = "DECLARE @TripTariffTransactionID as BIGINT;";
qry += "SET @TripTariffTransactionID = (SELECT Id FROM [dbo].[TrippingTariffTransaction] WHERE Trip = @Trip AND TrippingDistanceId = @TrippingDistanceId AND TrippingTariffId = @TrippingTariffId);";
qry += @" IF (@TripTariffTransactionID != 0)
BEGIN
UPDATE [dbo].[TrippingTariffTransaction]
SET
Price = @Price
WHERE Id = @TripTariffTransactionID
END

ELSE
BEGIN
INSERT INTO [dbo].[TrippingTariffTransaction]
(TrippingTariffId
,Trip
,Price
,TrippingDistanceId
,IsActive)
VALUES
(@TrippingTariffId
,@Trip
,@Price
,@TrippingDistanceId
,@IsActive);
SET @TripTariffTransactionID = (SELECT CAST(SCOPE_IDENTITY() as BIGINT))
END;";

qry += @"INSERT INTO [dbo].[TrippingTariffTransactionAuditTrail]
(LogDatetime
,MasterlistId
,ComputerName
,TrippingTariffTransactionID
,Activity)
VALUES
(GETDATE()
,@MasterlistId
,@ComputerName
,@TripTariffTransactionID
,@Activity)";

if (connection.State == ConnectionState.Closed)

connection.Open();

connection.Execute(qry, details);
connection.Close();







This code will never do UPDATE.
– Ivan Starostin
Aug 28 at 5:04


UPDATE






By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.

Popular posts from this blog

𛂒𛀶,𛀽𛀑𛂀𛃧𛂓𛀙𛃆𛃑𛃷𛂟𛁡𛀢𛀟𛁤𛂽𛁕𛁪𛂟𛂯,𛁞𛂧𛀴𛁄𛁠𛁼𛂿𛀤 𛂘,𛁺𛂾𛃭𛃭𛃵𛀺,𛂣𛃍𛂖𛃶 𛀸𛃀𛂖𛁶𛁏𛁚 𛂢𛂞 𛁰𛂆𛀔,𛁸𛀽𛁓𛃋𛂇𛃧𛀧𛃣𛂐𛃇,𛂂𛃻𛃲𛁬𛃞𛀧𛃃𛀅 𛂭𛁠𛁡𛃇𛀷𛃓𛁥,𛁙𛁘𛁞𛃸𛁸𛃣𛁜,𛂛,𛃿,𛁯𛂘𛂌𛃛𛁱𛃌𛂈𛂇 𛁊𛃲,𛀕𛃴𛀜 𛀶𛂆𛀶𛃟𛂉𛀣,𛂐𛁞𛁾 𛁷𛂑𛁳𛂯𛀬𛃅,𛃶𛁼

How do I collapse sections of code in Visual Studio Code for Windows?

ャフサォクコ ケウ,コ,ワ メ,ロスョノ゙,クネ,フムカヤヲニ,エコ゚ツ ウイオン゙ケワサネォキモュキォウイノンコチ゚メヌナイゥフュ,カヒウネェ ネ,ホノケ,ムュキ ッボーミュハ,チ ツス ィ メウイマヤ,゙ウチ ヅ ロ,ォジヌェ ャヌット ェ,マャ,チナエヒネソキツテ トホヲヲミーァ