Dfyjkt

I created 2 class.class KeyLogger and class cHookProc

first i create cHookProc in KeyLogger class.

then i get address of LRESULT CALLBACK cHookProc::HookProc by unsigned int cHookProc::getCallBackAddr()

is it logical and works fine always?

this is KeyLogger.h

#pragma once
#include <time.h>
#include <windows.h>

class cHookProc
public:
 LRESULT CALLBACK HookProc(int code, WPARAM wp, LPARAM lp);
 unsigned int getCallBackAddr();
private:
;

class KeyLogger
public:
 KeyLogger();
 ~KeyLogger();
private:
 cHookProc *cHkProc;
;

and this is KeyLogger.cpp

#include "KeyLogger.h"

KeyLogger::KeyLogger()
 cHkProc = new cHookProc;
 int i = cHkProc->getCallBackAddr();
 HOOKPROC hprc = (HOOKPROC)i;
 HHOOK keyHook = SetWindowsHookEx(WH_KEYBOARD_LL, hprc, NULL, NULL);

KeyLogger::~KeyLogger()
 delete cHkProc;


LRESULT CALLBACK cHookProc::HookProc(int code, WPARAM wp, LPARAM lp)
 if (code == 0)
 .
 .
 .
 
 return CallNextHookEx(NULL, code, wp, lp);

unsigned int cHookProc::getCallBackAddr()
 LRESULT(__stdcall cHookProc::*ptrtofn)(int, WPARAM, LPARAM) = &cHookProc::HookProc;
 unsigned int *i;
 i = (unsigned int*)&ptrtofn;
 return *i;

If your function doesn't use any method from the class, then it might work, but it's just random chance, and it will break if you change the function and add references to the object. Make it a static method in that case.

A callback on a method should be wrapped with a reference to the object on which the method is called.

Also use a unique pointer for cHkProc.