Jest Snapshot error when using React.memo
I am creating a file using React.memo (React 16.6.1).
I use jest 23.6 for snapshot.
// Work.js
import React, memo from "react";
const Work => (
/* codes */
);
export Work as WorkNaked;
export default memo(Work);
When saving the snapshot of a component rendering Work, it will render [object Object] instead of <Work />, which makes it difficult to maintain and debug later on.
// Container.js
import React, Component from "react";
export class Container extends Component
render ()
return (
<Work />
);
// Container-test.js
describe("Container component", () =>
const wrapper = shallow(<Container />);
it("should render contents with a proper slug", () =>
expect(wrapper).toMatchSnapshot();
);
);
So now we are forcing the name as follow:
// Work.js
export Work as WorkNaked;
const memoWork = memo(Work);
/* eslint-disable-next-line immutable/no-mutation */
memoWork.displayName = "memo(Work)";
export default memoWork;
which will render <memo(Work) /> in our Snapshot.
Isn't there a better/cleaner/simpler name to get the container name displayed when exporting it using React.memo ?
javascript reactjs jestjs
edited Nov 13 '18 at 6:56
skyboyer
4,08311230
asked Nov 13 '18 at 4:05
貝原匠貝原匠
467
add a comment |
I am creating a file using React.memo (React 16.6.1).
I use jest 23.6 for snapshot.
// Work.js
import React, memo from "react";
const Work => (
/* codes */
);
export Work as WorkNaked;
export default memo(Work);
When saving the snapshot of a component rendering Work, it will render [object Object] instead of <Work />, which makes it difficult to maintain and debug later on.
// Container.js
import React, Component from "react";
export class Container extends Component
render ()
return (
<Work />
);
// Container-test.js
describe("Container component", () =>
const wrapper = shallow(<Container />);
it("should render contents with a proper slug", () =>
expect(wrapper).toMatchSnapshot();
);
);
So now we are forcing the name as follow:
// Work.js
export Work as WorkNaked;
const memoWork = memo(Work);
/* eslint-disable-next-line immutable/no-mutation */
memoWork.displayName = "memo(Work)";
export default memoWork;
which will render <memo(Work) /> in our Snapshot.
Isn't there a better/cleaner/simpler name to get the container name displayed when exporting it using React.memo ?
javascript reactjs jestjs
edited Nov 13 '18 at 6:56
skyboyer
4,08311230
asked Nov 13 '18 at 4:05
貝原匠貝原匠
467
I think you may want to dive in theShallowWrapperand match the snapshot of the component itself.
– Oluwafemi Sule
Nov 13 '18 at 21:27
1
No, unittest should only test one component. The test for Work-test will use WorkNaked, but other components that use Work (and other stuff) will only see the memoized version of Work, so he wants to only print<memo(Work) />in that component's snapshot. It's annoying indeed that memo doesn't add the displayName by itself
– Fandekasp
Nov 14 '18 at 1:18
add a comment |
I am creating a file using React.memo (React 16.6.1).
I use jest 23.6 for snapshot.
// Work.js
import React, memo from "react";
const Work => (
/* codes */
);
export Work as WorkNaked;
export default memo(Work);
When saving the snapshot of a component rendering Work, it will render [object Object] instead of <Work />, which makes it difficult to maintain and debug later on.
// Container.js
import React, Component from "react";
export class Container extends Component
render ()
return (
<Work />
);
// Container-test.js
describe("Container component", () =>
const wrapper = shallow(<Container />);
it("should render contents with a proper slug", () =>
expect(wrapper).toMatchSnapshot();
);
);
So now we are forcing the name as follow:
// Work.js
export Work as WorkNaked;
const memoWork = memo(Work);
/* eslint-disable-next-line immutable/no-mutation */
memoWork.displayName = "memo(Work)";
export default memoWork;
which will render <memo(Work) /> in our Snapshot.
Isn't there a better/cleaner/simpler name to get the container name displayed when exporting it using React.memo ?
javascript reactjs jestjs
edited Nov 13 '18 at 6:56
skyboyer
4,08311230
asked Nov 13 '18 at 4:05
貝原匠貝原匠
467
I am creating a file using React.memo (React 16.6.1).
I use jest 23.6 for snapshot.
// Work.js
import React, memo from "react";
const Work => (
/* codes */
);
export Work as WorkNaked;
export default memo(Work);
When saving the snapshot of a component rendering Work, it will render [object Object] instead of <Work />, which makes it difficult to maintain and debug later on.
// Container.js
import React, Component from "react";
export class Container extends Component
render ()
return (
<Work />
);
// Container-test.js
describe("Container component", () =>
const wrapper = shallow(<Container />);
it("should render contents with a proper slug", () =>
expect(wrapper).toMatchSnapshot();
);
);
So now we are forcing the name as follow:
// Work.js
export Work as WorkNaked;
const memoWork = memo(Work);
/* eslint-disable-next-line immutable/no-mutation */
memoWork.displayName = "memo(Work)";
export default memoWork;
which will render <memo(Work) /> in our Snapshot.
Isn't there a better/cleaner/simpler name to get the container name displayed when exporting it using React.memo ?
javascript reactjs jestjs
javascript reactjs jestjs
edited Nov 13 '18 at 6:56
skyboyer
4,08311230
asked Nov 13 '18 at 4:05
貝原匠貝原匠
467
edited Nov 13 '18 at 6:56
skyboyer
4,08311230
asked Nov 13 '18 at 4:05
貝原匠貝原匠
467
edited Nov 13 '18 at 6:56
skyboyer
4,08311230
edited Nov 13 '18 at 6:56
skyboyer
4,08311230
edited Nov 13 '18 at 6:56
skyboyer
4,08311230
4,08311230
asked Nov 13 '18 at 4:05
貝原匠貝原匠
467
asked Nov 13 '18 at 4:05
貝原匠貝原匠
467
asked Nov 13 '18 at 4:05
貝原匠貝原匠
467
467
I think you may want to dive in theShallowWrapperand match the snapshot of the component itself.
– Oluwafemi Sule
Nov 13 '18 at 21:27
1
No, unittest should only test one component. The test for Work-test will use WorkNaked, but other components that use Work (and other stuff) will only see the memoized version of Work, so he wants to only print<memo(Work) />in that component's snapshot. It's annoying indeed that memo doesn't add the displayName by itself
– Fandekasp
Nov 14 '18 at 1:18
add a comment |
I think you may want to dive in theShallowWrapperand match the snapshot of the component itself.
– Oluwafemi Sule
Nov 13 '18 at 21:27
1
No, unittest should only test one component. The test for Work-test will use WorkNaked, but other components that use Work (and other stuff) will only see the memoized version of Work, so he wants to only print<memo(Work) />in that component's snapshot. It's annoying indeed that memo doesn't add the displayName by itself
– Fandekasp
Nov 14 '18 at 1:18
I think you may want to dive in the
ShallowWrapper and match the snapshot of the component itself.– Oluwafemi Sule
Nov 13 '18 at 21:27
I think you may want to dive in the
ShallowWrapper and match the snapshot of the component itself.– Oluwafemi Sule
Nov 13 '18 at 21:27
1
1
No, unittest should only test one component. The test for Work-test will use WorkNaked, but other components that use Work (and other stuff) will only see the memoized version of Work, so he wants to only print
<memo(Work) /> in that component's snapshot. It's annoying indeed that memo doesn't add the displayName by itself– Fandekasp
Nov 14 '18 at 1:18
No, unittest should only test one component. The test for Work-test will use WorkNaked, but other components that use Work (and other stuff) will only see the memoized version of Work, so he wants to only print
<memo(Work) /> in that component's snapshot. It's annoying indeed that memo doesn't add the displayName by itself– Fandekasp
Nov 14 '18 at 1:18
add a comment |
1 Answer
1
active
oldest
votes
It looks like you ran into an enzyme bug.
This pull request adds support for memo, which should render correctly inside of snapshots.
answered Mar 11 at 16:49
pbondoerpbondoer
149413
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53273627%2fjest-snapshot-error-when-using-react-memo%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
It looks like you ran into an enzyme bug.
This pull request adds support for memo, which should render correctly inside of snapshots.
answered Mar 11 at 16:49
pbondoerpbondoer
149413
add a comment |
It looks like you ran into an enzyme bug.
This pull request adds support for memo, which should render correctly inside of snapshots.
answered Mar 11 at 16:49
pbondoerpbondoer
149413
add a comment |
It looks like you ran into an enzyme bug.
This pull request adds support for memo, which should render correctly inside of snapshots.
answered Mar 11 at 16:49
pbondoerpbondoer
149413
It looks like you ran into an enzyme bug.
This pull request adds support for memo, which should render correctly inside of snapshots.
answered Mar 11 at 16:49
pbondoerpbondoer
149413
answered Mar 11 at 16:49
pbondoerpbondoer
149413
answered Mar 11 at 16:49
pbondoerpbondoer
149413
answered Mar 11 at 16:49
pbondoerpbondoer
149413
149413
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53273627%2fjest-snapshot-error-when-using-react-memo%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
I think you may want to dive in the
ShallowWrapperand match the snapshot of the component itself.– Oluwafemi Sule
Nov 13 '18 at 21:27
1
No, unittest should only test one component. The test for Work-test will use WorkNaked, but other components that use Work (and other stuff) will only see the memoized version of Work, so he wants to only print
<memo(Work) />in that component's snapshot. It's annoying indeed that memo doesn't add the displayName by itself– Fandekasp
Nov 14 '18 at 1:18