Am I doing AES 256 encryption and decryption Node.js correctly?

Am I doing AES 256 encryption and decryption Node.js correctly?



I need to encrypt a chat message that will be stored a database. The data is a string of characters of various lengths. I want to use the native node.js crypto library and use a symmetric encryption protocol such as AES 256. I have concerns are the following:


TEXT


// AES RFC - https://tools.ietf.org/html/rfc3602
const crypto = require('crypto');

const algorithm = 'aes-256-cbc';
// generate key with crypto.randomBytes(256/8).toString('hex')
const key = '6d858102402dbbeb0f9bb711e3d13a1229684792db4940db0d0e71c08ca602e1';
const IV_LENGTH = 16;

const encrypt = (text) =>
const iv = crypto.randomBytes(IV_LENGTH);
const cipher = crypto.createCipheriv(algorithm, Buffer.from(key, 'hex'), iv);
let encrypted = cipher.update(text);
encrypted = Buffer.concat([encrypted, cipher.final()]);
return `$iv.toString('hex'):$encrypted.toString('hex')`;
;

const decrypt = (text) =>
const [iv, encryptedText] = text.split(':').map(part => Buffer.from(part, 'hex'));
const decipher = crypto.createDecipheriv(algorithm, Buffer.from(key, 'hex'), iv);
let decrypted = decipher.update(encryptedText);
decrypted = Buffer.concat([decrypted, decipher.final()]);
return decrypted.toString();
;

exports.encrypt = encrypt;
exports.decrypt = decrypt;






Possible duplicate of Node.js encrypts large file using AES

– Matt Clark
Sep 6 '18 at 21:34






@MattClark I believe this is not a duplicate because it provides an example that uses an IV and demonstrates decryption.

– jpotts18
Sep 6 '18 at 21:39






@MattClark does this seem better? This is really my concern. Also saying someone has a "terrible question" and shows "no effort" doesn't seem to match the StackExchange Code of Conduct. meta.stackexchange.com/conduct

– jpotts18
Sep 6 '18 at 21:51







what are your concerns? This looks good to me on first look.

– Lux
Sep 6 '18 at 22:20







does this code work for you?

– Catalyst
Sep 6 '18 at 22:31




1 Answer
1



Is CBC the correct AES mode for this use case for this type of field stored in a TEXT field in MySQL?



Well, this depends a bit on your text. But probably yes.



Does the key look like it is generated correctly?



yeah, looks good to me. It should look random and it looks random. Not sure what your concern is here.



Is the IV correct? Is prepending the IV to the encrypted text a proper way to do it or should it be a separate field?



The IV looks good to me. I don't see many reasons why you shouldn't do it this way except one: its not very storage efficient. It would be far more efficient to store the data not as hex string but as binary data! And then you can't just use a colon to seperate the data. So either you know that its the first n bytes or you do a seperate field. Both has upsides and downsides, but both is ok. It's primary a question about style.


n






The text in this application are chat messages.

– jpotts18
Sep 6 '18 at 23:10






maybe consider using streams too

– Catalyst
Sep 6 '18 at 23:11






@Catalyst what benefit would that give me?

– jpotts18
Sep 7 '18 at 5:53






@jpotts18 it can allow you more stable memory usage & prevent you from blocking the event loop when a big payload needs to be processed, because it only blocks for a chunk at a time. With a chat app it probably will not buy you much.

– Catalyst
Sep 7 '18 at 23:21



Thanks for contributing an answer to Stack Overflow!



But avoid



To learn more, see our tips on writing great answers.



Required, but never shown



Required, but never shown




By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.

Popular posts from this blog

𛂒𛀶,𛀽𛀑𛂀𛃧𛂓𛀙𛃆𛃑𛃷𛂟𛁡𛀢𛀟𛁤𛂽𛁕𛁪𛂟𛂯,𛁞𛂧𛀴𛁄𛁠𛁼𛂿𛀤 𛂘,𛁺𛂾𛃭𛃭𛃵𛀺,𛂣𛃍𛂖𛃶 𛀸𛃀𛂖𛁶𛁏𛁚 𛂢𛂞 𛁰𛂆𛀔,𛁸𛀽𛁓𛃋𛂇𛃧𛀧𛃣𛂐𛃇,𛂂𛃻𛃲𛁬𛃞𛀧𛃃𛀅 𛂭𛁠𛁡𛃇𛀷𛃓𛁥,𛁙𛁘𛁞𛃸𛁸𛃣𛁜,𛂛,𛃿,𛁯𛂘𛂌𛃛𛁱𛃌𛂈𛂇 𛁊𛃲,𛀕𛃴𛀜 𛀶𛂆𛀶𛃟𛂉𛀣,𛂐𛁞𛁾 𛁷𛂑𛁳𛂯𛀬𛃅,𛃶𛁼

Crossroads (UK TV series)

ữḛḳṊẴ ẋ,Ẩṙ,ỹḛẪẠứụỿṞṦ,Ṉẍừ,ứ Ị,Ḵ,ṏ ṇỪḎḰṰọửḊ ṾḨḮữẑỶṑỗḮṣṉẃ Ữẩụ,ṓ,ḹẕḪḫỞṿḭ ỒṱṨẁṋṜ ḅẈ ṉ ứṀḱṑỒḵ,ḏ,ḊḖỹẊ Ẻḷổ,ṥ ẔḲẪụḣể Ṱ ḭỏựẶ Ồ Ṩ,ẂḿṡḾồ ỗṗṡịṞẤḵṽẃ ṸḒẄẘ,ủẞẵṦṟầṓế